Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4708: adding new APIs for adding/removing marker and marker events #165

Merged
merged 13 commits into from
Mar 8, 2024

Conversation

rugoncalves
Copy link
Contributor

This PR is for adding new public APIs, and respective changes, to allow creating markers and adding marker events through API, instead through blocks.

What was happening

  • When trying to add many markers into the map (> 500), the map became very slow
  • What caused a decrease in performance was the extra html created by the blocks

What was done

  • Added the code required to create new APIs in OutSystems to enable the creation of markers without blocks
  • Additionally added the code required to add the events to markers via API, as well

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves requested a review from a team as a code owner February 27, 2024 21:59
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rugoncalves rugoncalves merged commit e014979 into dev Mar 8, 2024
5 of 9 checks passed
@rugoncalves rugoncalves deleted the ROU-4708 branch March 8, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants